Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Remove NFT collection generetaion from NFT-Staking genesis #240

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

DidacSF
Copy link
Contributor

@DidacSF DidacSF commented Mar 22, 2023

Description

Removes staking contract holding collection from NFT-Staking genesis, adds new extrinsic set_contract_collection_id to set value.

Type of changes

  • build: Changes that affect the build system or external dependencies (eg, Cargo, Docker)
  • ci: Changes to CI configuration
  • docs: Changes to documentation only
  • feat: Changes to add a new feature
  • fix: Changes to fix a bug
  • refactor: Changes that do not alter functionality
  • style: Changes to format the code
  • test: Changes to add missing tests or correct existing tests

Checklist

  • Tests for the changes have been added
  • Necessary documentation is added (if appropriate)
  • Formatted with cargo fmt --all
  • Linted with cargo clippy --all-features --all-targets
  • Tested with cargo test --workspace --all-features --all-targets

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.03 🎉

Comparison is base (b1acfd1) 79.87% compared to head (8b8ee11) 79.91%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #240      +/-   ##
===========================================
+ Coverage    79.87%   79.91%   +0.03%     
===========================================
  Files           16       16              
  Lines         1123     1130       +7     
===========================================
+ Hits           897      903       +6     
- Misses         226      227       +1     
Impacted Files Coverage Δ
pallets/ajuna-nft-staking/src/lib.rs 86.03% <85.71%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

* Added new extrinsic for setting contract collection id
@DidacSF DidacSF force-pushed the ds/refactor-contract-staking branch from 1ebf2fc to b2c7d97 Compare March 22, 2023 14:43
@DidacSF DidacSF requested a review from darkfriend77 March 22, 2023 14:45
@DidacSF DidacSF self-assigned this Mar 22, 2023
cowboy-bebug
cowboy-bebug previously approved these changes Mar 23, 2023
Copy link
Contributor

@cowboy-bebug cowboy-bebug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pallets/ajuna-nft-staking/src/tests.rs Outdated Show resolved Hide resolved
darkfriend77 and others added 2 commits March 23, 2023 11:02
@darkfriend77 darkfriend77 merged commit 2a18df9 into develop Mar 23, 2023
@darkfriend77 darkfriend77 deleted the ds/refactor-contract-staking branch March 23, 2023 10:47
@DidacSF DidacSF mentioned this pull request Mar 23, 2023
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants