Improve support for using reckon on old commits #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continues using JSemver internally, but the API now leverages a custom Version class. Main benefit is that it speaks the domain of Reckon, e.g. stages. More refactoring should probably be done to take advantage of this.
Prepare for refactoring to remove the strategy classes and build them into the Reckoner. This puts all of the strategy tests at the Reckoner level, so it ensures that they'll apply when the logic from the strategies themselves is moved in there.
Consolidated into one class to handle all of the inference.
This includes a partial fix for #78.
Apply grgit by default, instead of requiring someone to apply it themselves. This has been a confusion point for a few users. Also, it's unlikely that I'll ever support more VCSs, so this just simplifies things for everyone. Additionally this meant starting to hide some methods from public visibility. I think there's more to do on that front.
On top of already allowing a rebuild of a tagged version that's already claimed, we should allow rebuilding insignificant versions. As noted in the issue, this allows use of git bisect on reckoned repos. This fixes #78.
SNAPSHOT should be treated like any other insignificant version.
Want a test to verify this until we remove the deprecated methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily driven by #78. Along the way, it involved some heavy refactoring to simplify some internals, partially related to that issue and partially just lingering issues.