minor: Allow commit messages to bump to 1.0.0 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in #204, I had unfortunately forced the preference to not allow commit messages to bump to v1 on all users of commit message scope calculators. In theory, I had meant to allow custom parsing, but the custom parsing still enforced the pre-1.0 special casing. The new approach implements a new ofCommitMessageParser() mechanism that has the parsing function accept both the commit message and a boolean indicating whether the project is pre-v1.0.0. This allows the user full control of the approach they want to use. To simplify adoption of this new capability the default commit message parser was enhanced to allow "major!: subject" prefixes that bypass the pre-1.0.0 check, allowing a more CD style bump to 1.0.0. Fixes #204
Set git config on test repos to avoid signing commits and tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #204, I had unfortunately forced the preference to not allow commit messages to bump to v1 on all users of commit message scope calculators. In theory, I had meant to allow custom parsing, but
the custom parsing still enforced the pre-1.0 special casing.
The new approach implements a new ofCommitMessageParser() mechanism that has the parsing function accept both the commit message and a boolean indicating whether the project is pre-v1.0.0. This allows the user full control of the approach they want to use.
To simplify adoption of this new capability the default commit message parser was enhanced to allow "major!: subject" prefixes that bypass the pre-1.0.0 check, allowing a more CD style bump to 1.0.0.