Rebuild fixes #113
Merged
Rebuild fixes #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the base normal and base version aren't within 1 major/minor/patch increment, there's something weird going on in the history, because the versions aren't contiguous. This may be something we need to support for parallel development at some point, but right now this makes it more explicit and allows specific use cases to be raised.
In some cases the inferred target normal would be different from the target normal of the final reckoned version. This can cause an issue if you're trying to release an older version and the inferred target normal is a version you already released. The code now verifies the normal version of the final reckoned version, rather than relying on the potentially incorrect target normal. This fixes #108.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.