-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception when only username is provided #153
Comments
We're also experiencing this issue in junit-team/junit5#782. Is there any workaround or a solution in sight? |
I think it will be a pretty easy fix, just haven't had time to look at it. May have some time tomorrow. |
Username-only creds are useful for things like GitHub access tokens. Prior to this commit, specifying only a username resulted in a null password, which caused an ambiguous method call to the UserNamePasswordCredentialsProvider constructor. Now Credentials has been beefed up to fallback to empty strings for values that aren't provided. There's also an explicit method for how to check the validity of a Credentials object rather than needing to specify it directly in each case. Fixes #153
Copying Marc's sample error to make this easier to find with search:
|
1.9.1 is out now. I'll be making fix releases of a bunch of the other plugins to update their dependencies on this too. |
Thanks for the quick turnaround! The new version works now! 👍 |
thanks for the fix: i hoped to have it! Maybe now the migrating doc https://github.com/ajoberstar/gradle-git-publish#migrating-from-orgajoberstargithub-pages could be changed, e.g. at least refer credentials section to http://ajoberstar.org/grgit/docs/groovydoc/index.html?org/ajoberstar/grgit/auth/AuthConfig.html ? |
GitHub auth token's can be passed as a username and no password, but currently taking a similar approach here using GRGIT_USER and no GRGIT_PASS will fail.
The text was updated successfully, but these errors were encountered: