-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for shark europe devices #11
base: master
Are you sure you want to change the base?
Conversation
Testet it with a Shark RV1100S1EU and can also confirm login works in EU |
@captrik great to hear! |
Hi, I testet it by manually running the PR version of this library with python (not the HA integration itself) as shown in the example in the Readme. The HA integration (which just uses this package) will need some changes too in order to work with the "europe option" |
I see, thanks. |
No this was completely independent from HA |
Understood, thanks for your quick feedback! |
@TheLastFrame given the API endpoint woes we're seeing again this week, I suspect the EU URLs may need to be updated as well. There is a PR open on the Home Assistant repo to update the shark dependency to a fork of this repo that is actively maintained. Could you check the URLs & resubmit your PR on that repo so we can get it merged in? https://github.com/JeffResc/sharkiq/ Should be plug & play for the most part. |
Oh nice, that someone finally does what I always wanted to do. |
Closed in active fork repo via JeffResc/sharkiq#16 |
Hi was the EU feature all merged and completed please? I get the 'unexpected error' message but unsure if it is to do with the EU issue, or something else. |
Hi, due to shark European devices using different servers then shark US devices, I added support for the European servers.
I tested it with the Shark RV1000SEU