Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for shark europe devices #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheLastFrame
Copy link

@TheLastFrame TheLastFrame commented Jun 25, 2021

Hi, due to shark European devices using different servers then shark US devices, I added support for the European servers.
I tested it with the Shark RV1000SEU

@captrik
Copy link

captrik commented Jan 6, 2022

Testet it with a Shark RV1100S1EU and can also confirm login works in EU

@creativeosmose
Copy link

@captrik great to hear!
I can't seem to make this branch work on HA, could you please give some indication on how you made it work ? (I assume that you did not use HACS)
Thanks!

@captrik
Copy link

captrik commented Jan 19, 2022

@captrik great to hear! I can't seem to make this branch work on HA, could you please give some indication on how you made it work ? (I assume that you did not use HACS) Thanks!

Hi, I testet it by manually running the PR version of this library with python (not the HA integration itself) as shown in the example in the Readme.

The HA integration (which just uses this package) will need some changes too in order to work with the "europe option"

@creativeosmose
Copy link

Hi, I testet it by manually running the PR version of this library with python (not the HA integration itself) as shown in the example in the Readme.

The HA integration (which just uses this package) will need some changes too in order to work with the "europe option"

I see, thanks.
By doing so, do you see it in HA? or is it only running independently?

@captrik
Copy link

captrik commented Jan 19, 2022

No this was completely independent from HA

@creativeosmose
Copy link

Understood, thanks for your quick feedback!

@TheLastFrame TheLastFrame mentioned this pull request Mar 28, 2022
@funkybunch
Copy link

funkybunch commented Mar 30, 2022

@TheLastFrame given the API endpoint woes we're seeing again this week, I suspect the EU URLs may need to be updated as well. There is a PR open on the Home Assistant repo to update the shark dependency to a fork of this repo that is actively maintained. Could you check the URLs & resubmit your PR on that repo so we can get it merged in? https://github.com/JeffResc/sharkiq/

Should be plug & play for the most part.

@TheLastFrame
Copy link
Author

Oh nice, that someone finally does what I always wanted to do.
I will look into it as soon as possible.

@funkybunch
Copy link

Closed in active fork repo via JeffResc/sharkiq#16

@gtisi
Copy link

gtisi commented Jan 9, 2023

Hi was the EU feature all merged and completed please? I get the 'unexpected error' message but unsure if it is to do with the EU issue, or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants