Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong event types and missing ace.require for ace-builds #5744

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Feb 12, 2025

Issue #, if available: #5743 #5742

Description of changes:

  • fix missing event types
  • fix ace.require for ace-builds
  • add ace-builds test package and script to test ace-builds with generated types

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@mkslanc mkslanc changed the title Type fixes require Fix wrong event types and missing ace.require for ace-builds Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (09bbe54) to head (ec633c9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5744   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files         598      598           
  Lines       43749    43749           
  Branches     7165     7165           
=======================================
  Hits        38094    38094           
  Misses       5655     5655           
Flag Coverage Δ
unittests 87.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightwing nightwing merged commit 9574e1e into ajaxorg:master Feb 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants