Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(forced-color): do not adjust the forced colors for the editor #5624

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

bassettsj
Copy link
Contributor

@bassettsj bassettsj commented Aug 13, 2024

Issue #5028, if available:

Description of changes:
For windows high contrast mode, we disable the colors changing to avoid conflicts with the theme by setting forced-colors-adjust: none;

Before

kitchen sink showing the forced colors emulation with the issue

After

kitchen sink showing the forced colors emulation showing that we don't override that forced colros

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

@bassettsj bassettsj marked this pull request as ready for review August 13, 2024 20:34
@akoreman
Copy link
Contributor

Thanks for your contribution, I think this is a fine workaround for now to prevent the issue. We should probably add a high-contrast theme to accommodate users who need/want a high contrast theme but we can do that later.

@akoreman akoreman merged commit c8f9df8 into ajaxorg:master Aug 21, 2024
1 check passed
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (0192880) to head (f2b605a).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5624   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files         594      594           
  Lines       43222    43222           
  Branches     7155     7155           
=======================================
  Hits        37568    37568           
  Misses       5654     5654           
Flag Coverage Δ
unittests 86.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants