replace innerHTML in showErrorMarker

[dimovpetar]

Make showErrorMarker CSP compliant.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

• No backwards incompatible changes were made to Ace's public interface which is defined through the main typings file (ace.d.ts) and its references:
  • https://github.com/ajaxorg/ace/blob/master/ace.d.ts
  • https://github.com/ajaxorg/ace/blob/master/ace-modes.d.ts
  • https://github.com/ajaxorg/ace/blob/master/ace-extensions.d.ts

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (f6a8d37) to head (d23582e).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5574   +/-   ##
=======================================
  Coverage   86.79%   86.79%           
=======================================
  Files         594      594           
  Lines       43126    43129    +3     
  Branches     7148     7149    +1     
=======================================
+ Hits        37431    37434    +3     
  Misses       5695     5695           

Flag	Coverage Δ
unittests	86.79% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nightwing]

Looks like this will escape the html twice, because it is escaped in

ace/src/layer/gutter.js

Line 78 in a3277ea

annoText = annoText ? lang.escapeHTML(annoText) : annotation.html || "";

and the tooltip uses innerHTML as well

ace/src/mouse/default_gutter_handler.js

Line 227 in a3277ea

this.setHtml(tooltipContent);

[dimovpetar]

I guess this PR can be merged after #5575 is resolved then. Or do you have any proposals how to avoid this issue?

[akoreman]

Now that #5602 has been merged you should be able to use gutterAnno.displayText here to avoid issues with the text being escaped twice and being rendered incorrectly.

[dimovpetar]

Done.
I also adapted line 101.