Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wrong doc comment * insert behaviour #5571

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented May 31, 2024

Issue #, if available: #5555 #5320

Description of changes:
This change should fix most of wrong newline adding asterisk insert behaviours

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.78%. Comparing base (a3277ea) to head (bf855cb).

Files Patch % Lines
src/mode/behaviour/cstyle.js 91.66% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5571   +/-   ##
=======================================
  Coverage   86.78%   86.78%           
=======================================
  Files         594      594           
  Lines       43017    43050   +33     
  Branches     7129     7137    +8     
=======================================
+ Hits        37331    37362   +31     
- Misses       5686     5688    +2     
Flag Coverage Δ
unittests 86.78% <95.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kungfooman
Copy link
Contributor

If anyone else wants to test:

git clone https://github.com/ajaxorg/ace/
cd ace
gh pr checkout 5571
node ./Makefile.dryice.js

Go to http://127.0.0.1/ace

I tested and works perfectly, thank you! Anyone has time for merge and release? This bug is too annoying, I want to get rid of it in my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants