-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add folding and behaviours for JSX #5479
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5479 +/- ##
==========================================
+ Coverage 86.52% 86.63% +0.10%
==========================================
Files 584 592 +8
Lines 42410 42812 +402
Branches 7060 7114 +54
==========================================
+ Hits 36696 37090 +394
- Misses 5714 5722 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This does not work for several cases
|
@mkslanc i think this should fix the issues with highlighting without adding much complexity, could you please take a look, and add tests for pairing in |
Thank you! Sure, will do |
Looks pretty good! I played around a bit with it and noticed one weird thing. In the video, the first time I insert Screen.Recording.2024-04-12.at.13.48.46.mov |
@akoreman The issue here is that after q=function a(){
}
<div></div> case when function a(){
}
<div></div> where it is compiled as jsx tag. same issue is present for regular expressions too, but since tags are usually not written in that context i am not sure if we need to add extra state for this case. |
ah yeah that makes sense, in that case it should only occur in the scenario I used in the video which should not occur in valid JSX/TSX files anyway. |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.