fix: set aria-live to textarea in a11y mode #5221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5221 +/- ##
=======================================
Coverage 87.22% 87.22%
=======================================
Files 565 565
Lines 45253 45253
Branches 6927 6929 +2
=======================================
Hits 39471 39471
Misses 5782 5782
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
This does make screen readers which currently ignore text area content read it, but is has some drawbacks. Some screen readers now read content twice. Whether this is a better place to be than what we have currently is up to opinion. Something like #5225 might be a better way to go, but does require riskier changes. |
|
Closing this PR since #5225 seems to be a better way to improve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: NA
Description of changes: In some browsers, some screen readers don't pick up changes we make to the textarea resulting in the screen reader not reading lines when navigating up/down. Trying whether seting
aria-liveto the textarea to explicitly tell the screen reader to read the full line when cursor changes is an improvement and whether is has drawbacks.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.