Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better way to extract css for csp environments #4899

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

nightwing
Copy link
Member

fixes #4897

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #4899 (1b0612b) into master (6ad3123) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4899      +/-   ##
==========================================
- Coverage   85.75%   85.74%   -0.01%     
==========================================
  Files         539      539              
  Lines       40627    40624       -3     
  Branches     6420     6419       -1     
==========================================
- Hits        34839    34835       -4     
- Misses       5788     5789       +1     
Flag Coverage Δ
unittests 85.74% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/autocomplete/popup.js 78.09% <100.00%> (ø)
src/ext/code_lens.js 91.54% <100.00%> (ø)
src/ext/error_marker.js 84.00% <100.00%> (ø)
src/incremental_search.js 76.08% <100.00%> (ø)
src/keyboard/emacs.js 50.16% <100.00%> (-0.49%) ⬇️
src/keyboard/vim.js 89.54% <100.00%> (ø)
src/snippets.js 86.97% <100.00%> (ø)
src/editor.js 82.46% <0.00%> (-0.15%) ⬇️
src/range.js 85.41% <0.00%> (+0.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anthonyryan1
Copy link

I can confirm this pull request is generating the CSS properly to satisfy all of my testing.

@andrewnester andrewnester merged commit 710cedc into master Aug 17, 2022
@andrewnester andrewnester deleted the fix-build-css branch August 17, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ace-builds: empty theme css since v1.9.0
3 participants