Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from atty to is-terminal #21

Merged

Conversation

matthiasgoergens
Copy link
Contributor

atty is unmaintained and has security vulnerabilities.

See GHSA-g98v-hv3f-hcfr

@matthiasgoergens matthiasgoergens changed the title Migrate from atty to is_terminal Migrate from atty to is_terminal Jul 10, 2023
@matthiasgoergens matthiasgoergens changed the title Migrate from atty to is_terminal Migrate from atty to is-terminal Jul 10, 2023
`atty` is unmaintained and has security vulnerabilities.

See GHSA-g98v-hv3f-hcfr
@jayvdb
Copy link
Contributor

jayvdb commented Jul 17, 2023

ping @aj-bagwell - please approve this workflow.

@matthiasgoergens
Copy link
Contributor Author

There's also std::io::IsTerminal. That's in the standard library, but only stable since 1.70.0, and we are currently supporting older 1.63, I think.

@aj-bagwell aj-bagwell merged commit b9de3a9 into aj-bagwell:master Jul 17, 2023
4 checks passed
matthiasgoergens added a commit to 0xmozak/mozak-vm that referenced this pull request Jul 19, 2023
Temporarily override where we get clio from, until a version that
includes aj-bagwell/clio#21 is released on
crates.io.
matthiasgoergens added a commit to 0xmozak/mozak-vm that referenced this pull request Jul 19, 2023
Temporarily override where we get clio from, until a version that
includes aj-bagwell/clio#21 is released on
crates.io.

Fixes https://github.com/0xmozak/mozak-vm/security/dependabot/1
@cpu
Copy link

cpu commented Jul 23, 2023

@aj-bagwell Would you be willing to cut a release with this fix included? 🙇

@aj-bagwell
Copy link
Owner

aj-bagwell commented Jul 27, 2023

It is now in v0.3.4

@cpu
Copy link

cpu commented Jul 27, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants