Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aiven_azure_privatelink_connection_approval test #953

Merged
merged 1 commit into from
Nov 9, 2022
Merged

add aiven_azure_privatelink_connection_approval test #953

merged 1 commit into from
Nov 9, 2022

Conversation

byashimov
Copy link
Contributor

About this change—what it does

  • adds aiven_azure_privatelink_connection_approval test
  • fixes add aiven_azure_privatelink_connection_approval docs
  • downgrades terraform-plugin-sdk to run multiple providers in tests

@byashimov byashimov requested a review from a team November 7, 2022 20:56
@byashimov byashimov force-pushed the byashimov-add-acc-privatelink-test branch from a4ea7f3 to 433a429 Compare November 7, 2022 20:58
@byashimov byashimov added the no changelog No changelog entries are required for this PR label Nov 7, 2022
ivan-savciuc
ivan-savciuc previously requested changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things:

  • Please run make docs, these two files should be added to this PR:
modified:   docs/data-sources/grafana.md
modified:   docs/resources/grafana.md
  • Can you please run it locally and add here results?

internal/service/vpc/resource_azure_privatelink_connection_approve_test.go Show resolved Hide resolved
Serpentiel
Serpentiel previously requested changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we should also have a changelog entry for this

internal/service/vpc/resource_azure_privatelink_connection_approve_test.go Show resolved Hide resolved
@byashimov byashimov force-pushed the byashimov-add-acc-privatelink-test branch from 433a429 to 0d949d8 Compare November 8, 2022 15:04
@byashimov byashimov removed the no changelog No changelog entries are required for this PR label Nov 8, 2022
@byashimov byashimov dismissed stale reviews from Serpentiel and ivan-savciuc November 8, 2022 15:06

done

ivan-savciuc
ivan-savciuc approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thought would be great to check Aiven VPC resources fields with ImportStateCheck, but it could be done in a separate PR

Serpentiel
Serpentiel approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel added the enhancement New feature or request label Nov 9, 2022
@ivan-savciuc ivan-savciuc merged commit 955220e into main Nov 9, 2022
@ivan-savciuc ivan-savciuc deleted the byashimov-add-acc-privatelink-test branch November 9, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-savciuc ivan-savciuc ivan-savciuc approved these changes

@Serpentiel Serpentiel Serpentiel approved these changes

Assignees

@ivan-savciuc ivan-savciuc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byashimov @ivan-savciuc @Serpentiel