Remove //third_party/gflags

See bazelbuild#11201
aiuto · Jun 8, 2020 · d076da6 · d076da6
1 parent 034b09e
commit d076da6
Show file tree

Hide file tree

Showing 41 changed files with 2 additions and 5,744 deletions.
diff --git a/src/BUILD b/src/BUILD
@@ -117,9 +117,6 @@ JAVA_TOOLS = [
                "//third_party/java/j2objc:embedded_tools_srcs",
                "//third_party/py/abseil:srcs",
                "//third_party/py/concurrent:srcs",
-               # TODO(laszlocsomor): delete "//third_party/py/gflags:srcs" after
-               # every script in @bazel_tools was migrated to use Abseil.
-               "//third_party/py/gflags:srcs",
                "//third_party/py/six:srcs",
                "//src/conditions:embedded_tools",
                "//src/tools/android/java/com/google/devtools/build/android:embedded_tools",

diff --git a/src/test/java/com/google/devtools/build/lib/blackbox/bazel/PythonToolsSetup.java b/src/test/java/com/google/devtools/build/lib/blackbox/bazel/PythonToolsSetup.java
@@ -16,18 +16,11 @@
 
 import com.google.devtools.build.lib.blackbox.framework.BlackBoxTestContext;
 import com.google.devtools.build.lib.blackbox.framework.ToolsSetup;
-import java.io.IOException;
 
 /** Setup for Bazel Python tools */
 public class PythonToolsSetup implements ToolsSetup {
   @Override
-  public void setup(BlackBoxTestContext context) throws IOException {
-    context.write(
-        "third_party/py/gflags/build",
-        "licenses([\"notice\"])"
-            + "package(default_visibility = [\"//visibility:public\"])"
-            + "py_library("
-            + "    name = \"gflags\","
-            + ")");
+  public void setup(BlackBoxTestContext context) {
+    // nothing needed to be done
   }
 }
diff --git a/src/test/shell/testenv.sh b/src/test/shell/testenv.sh
@@ -139,16 +139,6 @@ EOF
   cp -R ${langtools_dir}/* third_party/java/jdk/langtools
 
   chmod -R +w .
-
-  mkdir -p third_party/py/gflags
-  cat > third_party/py/gflags/BUILD <<EOF
-licenses(["notice"])
-package(default_visibility = ["//visibility:public"])
-
-py_library(
-    name = "gflags",
-)
-EOF
 }
 
 # Report whether a given directory name corresponds to a tools directory.

diff --git a/third_party/BUILD b/third_party/BUILD
@@ -31,7 +31,6 @@ filegroup(
         "//third_party/protobuf:srcs",
         "//third_party/py/abseil:srcs",
         "//third_party/py/concurrent:srcs",
-        "//third_party/py/gflags:srcs",
         "//third_party/py/mock:srcs",
         "//third_party/py/six:srcs",
         "//third_party/rules_python:srcs",

diff --git a/third_party/py/gflags/AUTHORS b/third_party/py/gflags/AUTHORS
diff --git a/third_party/py/gflags/BUILD b/third_party/py/gflags/BUILD
diff --git a/third_party/py/gflags/CONTRIBUTING.md b/third_party/py/gflags/CONTRIBUTING.md
diff --git a/third_party/py/gflags/COPYING b/third_party/py/gflags/COPYING
diff --git a/third_party/py/gflags/ChangeLog b/third_party/py/gflags/ChangeLog
diff --git a/third_party/py/gflags/MANIFEST.in b/third_party/py/gflags/MANIFEST.in
diff --git a/third_party/py/gflags/Makefile b/third_party/py/gflags/Makefile
diff --git a/third_party/py/gflags/PKG-INFO b/third_party/py/gflags/PKG-INFO
diff --git a/third_party/py/gflags/README b/third_party/py/gflags/README
diff --git a/third_party/py/gflags/README.md b/third_party/py/gflags/README.md
diff --git a/third_party/py/gflags/__init__.py b/third_party/py/gflags/__init__.py