Refactoring of build management #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstroemer
reviewed
Jan 30, 2025
There was a problem hiding this comment.
Minor things I noticed, looks nice!
Two points:
- We can postpone the Julia version discussion (and refactoring
Configto a "better" approach) to a future issue. - I think we (= I) should come up with a reduced test set that calls the least amount of small models possible (since those should be tested by IESopt.jl) and just tests the relevant Python functionality, since running tests on all versions might otherwise take quite some time?
| steps: | ||
| - name: "set UV version" | ||
| shell: bash | ||
| run: echo "VERSION_UV=0.5.25" >> $GITHUB_ENV |
There was a problem hiding this comment.
Might that conflict with a fixed uv version that we enforce somewhere else for reproducibility?
There was a problem hiding this comment.
This is just here so that all CI steps use the same version of uv (and we can easily change this version in one location).
But I agree, its not optimal. Developers can use different uv versions locally, and I don't think we have any way to control that. It's probably not an big deal anyway, I just wanted the CI build to run with a well-defined uv version.
Co-authored-by: Stefan Strömer <8915976+sstroemer@users.noreply.github.com>
hkoller
commented
Jan 31, 2025
|
LGTM! Seems like we can merge this - or is there anything left open that would fit here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various updates to the build system:
uv#31 )