-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate tests #141
Separate tests #141
Conversation
Seeing the end result, I think we're moving in the wrong direction (including #134). Normally So we could also do:
And skip tests automatically, by adding this to if (!process.env.CI && !auth.username && !auth.key) {
t.skip('no sauce labs credentials provided')
return t.end()
} else if (!auth.username || !auth.key) {
t.fail('incomplete sauce labs credentials provided')
return t.end()
} I'm on the fence, neither solution is 100% clean. |
Sounds good. I got carried away :) |
67fb1cc
to
6635dde
Compare
@vweevers Updated. |
Weird, seems like travis built an older commit:
Restarting the build. |
key: auth.key, | ||
concurrency: 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh that feels goood
@ralphtheninja mind pushing a dummy commit? Something is borked in Travis or the git history |
6635dde
to
438b0de
Compare
This cleans up the scripts a bit.
I also wanted everything to be named as tests, since they are actually tests.Running tests locally by e.g.npm test
will test everything but the sauce browser tests, which can be run separately bynpm run test:sauce
.Travis runsnpm run test:all
which tests everything.Closes #140
Will squash.