Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make return RecordMetada if not no_confirm, change annotations and convert Doc to doc string. #1983

Merged
merged 6 commits into from
Dec 14, 2024

Conversation

spataphore1337
Copy link
Contributor

Description

If the publish and publish_batch method is called on Kafka with the no_confirm parameter, RecordMetadata will be returned. Also corrected annotations to match the new return type of publishers, and Doc annotations have been converted to doc string.

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

Copy link
Member

@Lancetnik Lancetnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you forgot:

  1. correct broker.publish and broker.publish_batch annotations
  2. add test, validating broker.publish result type
    Also, you have some conflicts with 0.6.0 branch you should solve before merge

@Lancetnik Lancetnik merged commit acf1d8c into airtai:0.6.0 Dec 14, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants