Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a bug when using one register for several middleware #1921

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

roma-frolov
Copy link
Contributor

@roma-frolov roma-frolov commented Nov 15, 2024

Description

If you use one register for several middleware, then a metric registration conflict occurs.

Error:

ValueError: Duplicated timeseries in CollectorRegistry: {'faststream_received_messages_created', 'faststream_received_messages', 'faststream_received_messages_total'}

The error occurs here when trying to register a duplicate metric into a register

Type of change

  • Bug fix (a non-breaking change that resolves an issue)

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik
Copy link
Member

I think, we shouldn't rash with this PR and take a break to discuss the problem

@Lancetnik
Copy link
Member

@draincoder can you help us here?

@Lancetnik Lancetnik added bug Something isn't working question Further information is requested labels Nov 15, 2024
@Lancetnik Lancetnik added this pull request to the merge queue Nov 19, 2024
Merged via the queue into airtai:main with commit 53e435e Nov 19, 2024
32 checks passed
@roma-frolov roma-frolov deleted the prom-fix branch November 19, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants