added ${Name} as variable for save path (CLI only) #623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using blobsaver with a lot of different devices (awesome project BTW :). The saved blobs can currently only be uniquely identified by the ECID, Generator or APNonce, none of which are easy to remember when working with multiple different devices. IMO it would be easier to save the blobs into a subdirectory with a name one can specify, i.e. the "saved device" name.
With the current changes this only works in CLI mode for imported/saved devices when requesting in background (my use-case).
However if you want I can add further changes to make it possible in the GUI as well:
I propose a new "Name" field in the GUI, possibly above the ECID field. This would make the "Name Device" popup obsolete (at least when a name is already given). Then when building the TSS object the Name would be accessible in Controller.java:656 (createTSS).