Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this only core features? #1

Open
mattip opened this issue May 15, 2023 · 1 comment
Open

Is this only core features? #1

mattip opened this issue May 15, 2023 · 1 comment

Comments

@mattip
Copy link
Contributor

mattip commented May 15, 2023

What are the core features? Is the mem.py and peakmem.py really core?

@HaoZeke
Copy link
Member

HaoZeke commented May 15, 2023

This was refactored this way to keep backwards compatibility, while peakmem.py is pure python and so can reasonably be here, having mem.py here (with its implicit CPython only pympler dependency) isn't ideal, but I couldn't think of a good enough reason to spin it out and still make it a required base dependency (BC, all downstream projects expect asv to come with Memory benchmarks).

By core it really just means what was in asv.benchmark as discussed in airspeed-velocity/asv#1286

HaoZeke pushed a commit that referenced this issue Jul 8, 2023
Co-authored-by: Sourcery AI <>
HaoZeke added a commit that referenced this issue Jul 8, 2023
MAINT: 'Refactored by Sourcery' (#1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants