Allow asv run
to consume list of hashes from a file
#768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the listing of hashes asv should run on by providing a file. Currently the format is intentionally limited to "one hash per line". The user says they want to use said file by giving "HASHFILE:xxx.yyy" as the
range
parameter toasv run
. While not strictly a "range", this seemed ok because "ANY", "EXISTING", etc were already options, so this seems not too much farther from "range" than those.The use case for this is wanting to compare a specific hand-picked set of commits to so how performance on a particular feature evolves with major known (also probably #561, if I understand the suggestion there correctly). To try to also address the use case #562 is going for, I added "stdin" or "-" as options, in which case stdin is treated as the "hash file", although if that's too hacky I could drop that commit.
I know I could do one of the tricks suggested in #562 instead of this, but those are a lot harder to grok, and also seem to preclude the use of some of the nice multi-commit features of
asv run
like--parallel
or--interleave-processes
.Happy to add docs/etc if need be - just "testing the waters" for now, as I found it quite frustrating to not have an easy way to just run on a list of known hashes.
Closes #562