Escape # in filename url #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git+https://github.com/org/project#egg=project can have # in the name and it should be escaped when used in a URL
pv
requested changes
Aug 29, 2018
asv/www/asv.js
Outdated
| @@ -239,6 +239,7 @@ $(document).ready(function() { | |||
| "LPT2", "LPT3", "LPT4", "LPT5", "LPT6", "LPT7", "LPT8", | |||
| "LPT9"]; | |||
| name = name.replace(bad_re, "_"); | |||
| name = name.replace("#", "%23"); | |||
There was a problem hiding this comment.
Also take the comment above "The implementation must match asv.util.sanitize_filename" into account.
There was a problem hiding this comment.
This is just escaping the # character. Filename is the same.
There was a problem hiding this comment.
Or, possibly, this is not the right place to do the url quoting, but it should be done at the point where the json request is made.
There was a problem hiding this comment.
The replacement should be done in graph_to_path, so that the comment does not become false.
pv
approved these changes
Aug 29, 2018
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git+https://github.com/org/project#egg=project can have # in the name and it should be escaped when used in a URL