Minor refactoring in benchmark runner #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The routine is somewhat more naturally written as a generator.
…decreasing The printing of right-aligned "result" messages should be dealt with in asv.console, so move it there. Make Log.set_nitems ensure that the percentage number is non-decreasing, even if the function is called several times. However, if 100% was already reached, the count is restarted from zero.
…ted benchmarks Follow-up to 9f060d5 (airspeed-velocitygh-593) for the skip_benchmarks() method.
The benchmark results have many properties, and it is clearer to represent them with named attributes rather than free-form dicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various minor refactorings of the benchmark runner code paths, moving pieces of code to more appropriate locations.