Add branch state in url on regression page #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pv
requested changes
Jan 20, 2018
asv/www/regressions.js
Outdated
| if (branches && branches.length > 1) { | ||
| current_title = "Regressions in " + branches[0] + " branch"; | ||
| var info = $.asv.parse_hash_string(window.location.hash); | ||
| if (info.params.branch) { |
There was a problem hiding this comment.
Probably no need to re-parse the location hash.
params is passed to this function (see line 45, 53)
There was a problem hiding this comment.
Indeed, changed to use params directly.
philpep
force-pushed
the
regresion-branch-url
branch
from
79c0845 to
f7a405f
Compare
pv
requested changes
Jan 27, 2018
asv/www/regressions.js
Outdated
| if (branches && branches.length > 1) { | ||
| current_title = "Regressions in " + branches[0] + " branch"; | ||
| if (params.branch) { | ||
| branch_index = branches.indexOf(info.params.branch[0]); |
Add a 'branch' parameter in the url so the branch selection can be shared through the url.
pv
force-pushed
the
regresion-branch-url
branch
from
f7a405f to
452b786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a 'branch' parameter in the url so the branch selection can be
shared through the url.