Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a less hacky way to launch virtualenv #555

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

pv
Copy link
Collaborator

@pv pv commented Sep 26, 2017

No description provided.

# .pyc file which can't be used on another version of Python
self._virtualenv_path = os.path.abspath(
inspect.getsourcefile(virtualenv))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that import inspect is now unused in this file.

LGTM otherwise.

@pv pv force-pushed the virtualenv-removehack branch from 7dc90f9 to e88227d Compare September 27, 2017 18:47
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 87.048% when pulling e88227d on pv:virtualenv-removehack into a60250d on spacetelescope:master.

@pv pv merged commit 3570fd8 into airspeed-velocity:master Sep 27, 2017
pv added a commit to pv/asv that referenced this pull request Jul 8, 2018
Use a less hacky way to launch virtualenv

(cherry picked from commit 3570fd8)
pv added a commit to pv/asv that referenced this pull request Jul 8, 2018
…hack

Use a less hacky way to launch virtualenv

(cherry picked from commit 3570fd8)
@pv pv deleted the virtualenv-removehack branch August 19, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants