Use configured branches when no commit/range is specified #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From 160s to 60s by running only one benchmark and reinstall a backup of
initial results and skipping existing commit (for ALL spec).
Also remove unneeded --skip-existing-{succesful,failed} in first commit
run.
philpep
force-pushed
the
fix-no-spec-ignore-conf-branches
branch
from
b7e237c to
6d56c44
Compare
Fix behavior of run, profiling and continuous commands that were using get_hash_from_master() instead of configured branches when no commit was specified. In particular when only one branch was configured and was not "master", asv tried to use the "master" branch. Add (and refactor) specific test. Closes airspeed-velocity#364
philpep
force-pushed
the
fix-no-spec-ignore-conf-branches
branch
from
6d56c44 to
0381e59
Compare
philpep
changed the title
|
|
||
| assert set(result_files) == expected | ||
|
|
||
| for branches, expected_commits in ( |
There was a problem hiding this comment.
Style nitpick: I'd prefer to write multiline for assignments as
branches_and_commits = (
...
)
for branches, expected_commits in branches_and_commits:
...
|
LGTM, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix behavior of run, profiling and continuous commands that were using
get_hash_from_master() instead of configured branches when no commit was
specified.
In particular when only one branch was configured and was not "master",
asv tried to use the "master" branch.
Add (and refactor) specific test.
Closes #364
Alternative to #387