Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude/include rules in config #329

Merged
merged 3 commits into from
Oct 27, 2015

Conversation

pv
Copy link
Collaborator

@pv pv commented Oct 14, 2015

Exclude/include rules in configuration.

The present approach is sort of a ripoff from how Travis-CI does it.

Addresses gh-322

  • fix bugs
  • environment_type and sys_platform perhaps should be allowed in include, but act as filters, similarly as in exclude? This would allow easy specification of os/environment dependent rules.

@mdboom
Copy link
Collaborator

mdboom commented Oct 15, 2015

Thanks for this. I agree that ripping off Travis-CI makes a lot of sense -- for familiarity's sake if nothing else.

@pv pv force-pushed the conditional-config branch 2 times, most recently from de62db3 to 37cbdb1 Compare October 15, 2015 18:25
@pv pv force-pushed the conditional-config branch from 37cbdb1 to 251ac19 Compare October 22, 2015 19:43
@pv pv changed the title WIP: exclude/include rules in config exclude/include rules in config Oct 22, 2015
@mdboom
Copy link
Collaborator

mdboom commented Oct 27, 2015

I really like this. Very cool.

mdboom added a commit that referenced this pull request Oct 27, 2015
exclude/include rules in config
@mdboom mdboom merged commit b9bdf37 into airspeed-velocity:master Oct 27, 2015
@pv pv deleted the conditional-config branch August 19, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants