BUG: Fix compare and continuous #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoZeke
commented
Aug 11, 2024
| cmd = ["in-dir={env_dir} python -mpip install {wheel_file}"] | ||
| # --force-reinstall is needed since versions may not change between | ||
| # asv runs (esp. for compare), e.g. gh-1421 | ||
| cmd = ["in-dir={env_dir} python -mpip install {wheel_file} --force-reinstall"] |
There was a problem hiding this comment.
--force-reinstall (basically the same as pip uninstall && pip install is used here, but -I might also be the "right thing to do" for testing commits as long as the files have not changed.
There was a problem hiding this comment.
I'd have also been open to simply documenting the fix described in #1417 (comment) but it seems like an issue a lot of people might have.
|
I think it is fine to drop pypy3.8. It is no longer supported, and tests are timing out. |
Co-authored-by: mattip <mattip@users.noreply.github.com>
|
Makes sense, should be good to go now. |
|
Thanks @HaoZeke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1417. Closes #1414 by improving the usage documentation.