-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow asv.conf.jsonc
file by default
#1420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the .jsonc
file extension widely known / used? If not I don't know that this would make sense to explicitly search for from an ASV perspective, given that this is mostly run in CI anyway and since passing the file works via --config
500ish stars on Microsoft's parser (https://github.com/microsoft/node-jsonc-parser), so not widely known, but also not niche IMO. My reason for opening this PR is that appending But no worries if this seems like more hassle than it is worth - I was just hoping that I could change to The same applies to code blocks in conversation messages: json: // a comment jsonc: // a comment |
OK then I'd say it'd be in scope, since anything to make using ASV more ergonomic is a win, left some suggestions for a refactor though. |
let me know if this is what you had in mind with |
Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
thanks @HaoZeke ! Let me know if I can help make an asv release happen, btw - I would like to patch SciPy once this is released. |
Sure, I'm planning to cut a new release today, and add some documentation on how we manage them and what the tasks generally are (fairly standard but good to have written down). Maybe a |
In SciPy, we have lots of comments in our
asv.conf.json
file. But comments are not allowed in JSON files (hence developers on GitHub or VSCode see lots of red highlighting).This PR allows the config file to be named
asv.conf.jsonc
(a JSON with comments file), without having to pass the name to--config
.