Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of Result.env in profiling code #1404

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Replace use of Result.env in profiling code #1404

merged 4 commits into from
Aug 12, 2024

Conversation

brandonwillard
Copy link
Contributor

Closes #801

@brandonwillard brandonwillard changed the title Fix use of results.env Fix use of result.env Jun 4, 2024
@brandonwillard brandonwillard changed the title Fix use of result.env Replace use of result.env Jun 4, 2024
@brandonwillard brandonwillard force-pushed the fix-profile-result-env branch from 1dfca26 to 6695e6c Compare June 4, 2024 21:23
@brandonwillard brandonwillard changed the title Replace use of result.env Replace use of result.env in profiling code Jun 4, 2024
@brandonwillard brandonwillard changed the title Replace use of result.env in profiling code Replace use of Result.env in profiling code Jun 4, 2024
@brandonwillard brandonwillard force-pushed the fix-profile-result-env branch from 6695e6c to c0d7f0b Compare June 4, 2024 21:26
HaoZeke
HaoZeke approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, could you prefix the commit with ENH?

@brandonwillard brandonwillard force-pushed the fix-profile-result-env branch from c0d7f0b to db6d082 Compare July 2, 2024 14:40
@HaoZeke
Copy link
Member

HaoZeke commented Jul 23, 2024

Sorry to get back to this so late, could you look into the test failure? I think its ok to also xfail on PyPy with a note

@brandonwillard
Copy link
Contributor Author

Sorry to get back to this so late, could you look into the test failure? I think its ok to also xfail on PyPy with a note

I can't tell how/if it relates to the changes in this PR, so I can't really help here.

@HaoZeke HaoZeke merged commit d62133a into airspeed-velocity:main Aug 12, 2024
13 checks passed
@HaoZeke
Copy link
Member

HaoZeke commented Aug 12, 2024

Thanks @brandonwillard

@brandonwillard brandonwillard deleted the fix-profile-result-env branch August 16, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoZeke HaoZeke HaoZeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

running profile without commit results in obscure AttributeError: 'Results' object has no attribute 'env'
2 participants
@brandonwillard @HaoZeke