Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: fix instances of get in mamba plugin #1357

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Jan 5, 2024

It expects a list, but with .get it can return None

@HaoZeke HaoZeke changed the title fix instances of get in mamba plugin MAINT: fix instances of get in mamba plugin Jan 7, 2024
@HaoZeke
Copy link
Member

HaoZeke commented Jan 7, 2024

Thanks for this @hmaarrfk, could you rename your commit to have MAINT: as a prefix?

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 7, 2024

done.

@HaoZeke HaoZeke merged commit f2a1755 into airspeed-velocity:master Jan 8, 2024
12 checks passed
@HaoZeke
Copy link
Member

HaoZeke commented Jan 8, 2024

Thanks @hmaarrfk 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants