Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Parse pip in env better #1331

Merged
merged 17 commits into from
Sep 10, 2023
Merged

BUG: Parse pip in env better #1331

merged 17 commits into from
Sep 10, 2023

Conversation

HaoZeke
Copy link
Member

@HaoZeke HaoZeke commented Aug 23, 2023

Closes #1326.

@HaoZeke HaoZeke mentioned this pull request Aug 23, 2023
Closed
@HaoZeke HaoZeke requested a review from mattip August 23, 2023 23:28
@mattip
Copy link
Contributor

mattip commented Aug 24, 2023

Is there a way to test this?

@HaoZeke
Copy link
Member Author

HaoZeke commented Aug 24, 2023

Is there a way to test this?

Yup, reworked and added tests.

@HaoZeke HaoZeke force-pushed the parsePipInEnvBetter branch 2 times, most recently from e2bfa74 to cfee427 Compare August 24, 2023 09:43
@HaoZeke
Copy link
Member Author

HaoZeke commented Aug 24, 2023

Should be good to go now @mattip, since the pypy tests are still flakey on the CI (will reopen the older issue on it).

@mattip
Copy link
Contributor

mattip commented Aug 24, 2023

Appveyor is unhappy, there are two failed tests

@HaoZeke HaoZeke force-pushed the parsePipInEnvBetter branch from 5a43427 to 2d8346c Compare August 24, 2023 15:45
@HaoZeke
Copy link
Member Author

HaoZeke commented Sep 3, 2023

Also fixes the unintended regression noted by sympy w.r.t virtualenv environments.

@HaoZeke
Copy link
Member Author

HaoZeke commented Sep 3, 2023

PyPy failure is unrelated, should be good to go @mattip :)

@mattip
Copy link
Contributor

mattip commented Sep 10, 2023

There is a merge conflict.

@HaoZeke
BUG: Rework parsing of pip keys in mamba
696c67e 
Closes airspeed-velocity#1326
@HaoZeke
DOC: Add changelog
9f89a27
@HaoZeke
MAINT: Don't clobber -e, local usage
452c24b
@HaoZeke
TST: Add tests
5ceefc2
@HaoZeke
MAINT: Modify regex for tests
24ade96
@HaoZeke
ENH: Rework pip handling completely
71f7878
@HaoZeke
TST: Add tests for new pip argument handler
8034f6b
@HaoZeke
TST: Add tests for construct_pip_call
b1fde22
@HaoZeke
MAINT: Simplify handling for pip mamba
a1fcec7
@HaoZeke
MAINT: Use new construct_pip_call everywhere
6838c1a
@HaoZeke
MAINT: Don't use pip_args in conda anymore
47b9034
@HaoZeke
MAINT: Clarify test (use the right versions)
affa4f0
@HaoZeke
BUG: Restore earlier behavior of virtualenv plugin
95d0294 
Installs with pip by default
@HaoZeke
ENH: Use named groups, be more robust
47da450
@HaoZeke
TST: Test for versions without specifiers
31cc42d
@HaoZeke
MAINT: Pass values to pip declaration parser
844f1f9
@HaoZeke
MAINT: Handle more pip parser corner cases
773bf7d
@HaoZeke HaoZeke force-pushed the parsePipInEnvBetter branch from 2dc869a to 773bf7d Compare September 10, 2023 14:16
@HaoZeke
Copy link
Member Author

HaoZeke commented Sep 10, 2023

There is a merge conflict.

Fixed now :)

@mattip mattip merged commit 935be55 into airspeed-velocity:master Sep 10, 2023
@mattip
Copy link
Contributor

mattip commented Sep 10, 2023

I merged this, perhaps a future refactor could leverage conda/mamba rather than re-implementing the logic here.

@HaoZeke HaoZeke deleted the parsePipInEnvBetter branch September 10, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattip mattip Awaiting requested review from mattip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mamba plugin in asv 0.6.0: ValueError: too many values to unpack (expected 2)
2 participants
@HaoZeke @mattip