Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: use setuptools-scm for versioning #1134

Merged
merged 8 commits into from
Mar 11, 2022
Merged

BLD: use setuptools-scm for versioning #1134

merged 8 commits into from
Mar 11, 2022

Conversation

fangchenli
Copy link
Contributor

No description provided.

datapythonista
datapythonista reviewed Mar 11, 2022
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice clean up. Did you check if there is a test for this? Would be nice to know with a CI test if this is working as expected.

@fangchenli
Copy link
Contributor Author

fangchenli commented Mar 11, 2022 •
edited
Loading

Very nice clean up. Did you check if there is a test for this? Would be nice to know with a CI test if this is working as expected.

There is no explicit test just for this. But there are tests using asv.__version__ which is written by setuptools-scm. Also, if it doesn't work, we couldn't even import asv.

@datapythonista datapythonista merged commit 969b285 into airspeed-velocity:master Mar 11, 2022
@datapythonista
Copy link
Member

Cool. Sounds good, thanks for the clean up!

@fangchenli fangchenli deleted the use-setuptools-scm branch March 11, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fangchenli @datapythonista