Replace format() function with f-strings on asv/console.py #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2af36bf.
…o airspeed-velocity-master
LucyJimenez
changed the title
|
@datapythonista, this PR is ready for your review. Thanks a lot! |
asv/console.py
Outdated
| @@ -218,8 +218,7 @@ def _stream_formatter(self, record): | |||
| continued = getattr(record, 'continued', False) | |||
|
|
|||
| if self._total: | |||
| progress_msg = '[{0:6.02f}%] '.format( | |||
| (float(self._count) / self._total) * 100.0) | |||
| progress_msg = f'[{(float(self._count) / self._total) * 100.0:6.02f}%] ' | |||
There was a problem hiding this comment.
This is very difficult to read, you can define a variable instead.
asv/console.py
Outdated
| progress_msg = '[{0:6.02f}%] '.format( | ||
| (float(self._count) / self._total) * 100.0) | ||
| percentage = (float(self._count) / self._total) * 100.0 | ||
| progress_msg = f'[{percentage:6.02f}%] ' |
There was a problem hiding this comment.
The original code wasn't great. In Python you can actually do this:
>>> value = .2
>>> f'{value:.2%}'
'20.00%'Also, converting self._count to float only made sense in Python 2, in Python 3 it's not needed. So, this could be something like (make sure we're not changing the result):
progress_msg = f'[{self._count / self._total:6.02%}] 'There was a problem hiding this comment.
Done! thanks for the suggestion :)
|
Thanks @LucyJimenez, nice clean up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #1077
Change f-strings instead
.format()onasv/console.py.