Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example_results() fixture to conftest.py file #1110

Merged

Conversation

dorothykiz1
Copy link
Contributor

xref #1030

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor comment, and also you've got conflicts to solve. And let's see if the CI is happy.

test/conftest.py Outdated
Comment on lines 8 to 9
import shutil
from os.path import abspath, dirname
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The imports from Python's standard library should come first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me fix them

@dorothykiz1
Copy link
Contributor Author

@datapythonista this PR is ready for your review

@datapythonista datapythonista merged commit 3c5d7ad into airspeed-velocity:master Mar 7, 2022
@datapythonista
Copy link
Member

Thanks @dorothykiz1, really nice clean up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants