Fix flake8 issues on asv/commands folder #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
requested changes
Mar 2, 2022
asv/commands/check.py
Outdated
| @@ -42,4 +40,5 @@ def run(cls, conf, env_spec=None): | |||
| commit_hashes = [] # use fallback defaults | |||
| benchmarks = Benchmarks.discover(conf, repo, environments, commit_hashes, | |||
| check=True) | |||
| benchmarks | |||
asv/commands/find.py
Outdated
| @@ -100,7 +100,8 @@ def run(cls, conf, range_spec, bench, invert=False, show_stderr=False, parallel= | |||
| elif len(benchmarks) > 1: | |||
| exact_matches = benchmarks.filter_out([x for x in benchmarks if x != bench]) | |||
| if len(exact_matches) == 1: | |||
| log.warning("'{0}' matches more than one benchmark, using exact match".format(bench)) | |||
| log.warning("'{0}' matches more than one benchmark," | |||
There was a problem hiding this comment.
There is a missing space after the comma
asv/commands/profiling.py
Outdated
| @@ -180,7 +180,8 @@ def run(cls, conf, benchmark, revision=None, gui=None, output=None, | |||
| elif len(benchmarks) > 1: | |||
| exact_matches = benchmarks.filter_out([x for x in benchmarks if x != benchmark]) | |||
| if len(exact_matches) == 1: | |||
| log.warning("'{0}' matches more than one benchmark, using exact match".format(benchmark)) | |||
| log.warning("'{0}' matches more than one benchmark," | |||
asv/commands/run.py
Outdated
| @@ -214,8 +214,8 @@ def run(cls, conf, range_spec=None, steps=None, date_period=None, | |||
| if dry_run: | |||
| raise util.UserError("--interleave-rounds and --dry-run cannot be used together") | |||
| if has_existing_env: | |||
| raise util.UserError("--interleave-rounds cannot be used with existing environment " | |||
| "(or python=same)") | |||
| raise util.UserError("--interleave-rounds cannot be used with" | |||
|
I will split this PR into small tasks to easily review the errors. |
datapythonista
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #1065
Clean out all the files to follow Flake8 standards on the asv/commands folder.