Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove six import and replace all with python 3 equivalent #1047

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Remove six import and replace all with python 3 equivalent #1047

merged 2 commits into from
Feb 23, 2022

Conversation

dorothykiz1
Copy link
Contributor

xref #1040

@dorothykiz1
Copy link
Contributor Author

@datapythonista this PR is ready for your review

datapythonista
datapythonista reviewed Feb 21, 2022
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is this file now passing flake8 checks? Should we remove it from the exclude?

@dorothykiz1
Copy link
Contributor Author

@datapythonista Yes it is , passing all flake8 checks

@datapythonista
Copy link
Member

@datapythonista Yes it is , passing all flake8 checks

Can you remove it from the exclude then please?

@dorothykiz1
Copy link
Contributor Author

@datapythonista this PR is ready for your review

@datapythonista datapythonista merged commit fa7e7cf into airspeed-velocity:master Feb 23, 2022
@datapythonista
Copy link
Member

Thanks @datapythonista, very nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorothykiz1 @datapythonista