Fix flake8 violations #1018
Fix flake8 violations #1018
Conversation
asv/__init__.py
Outdated
| @@ -29,4 +29,4 @@ | |||
| if os.environ.get('__PYVENV_LAUNCHER__'): | |||
| os.unsetenv('__PYVENV_LAUNCHER__') | |||
|
|
|||
| from . import plugin_manager | |||
| from . import plugin_manager # noqa this dependency is not used here but it may be used in other files | |||
There was a problem hiding this comment.
What's the error that you are receiving here, if this unused import is removed?
You should add the error code to ignore, not just use noqa
There was a problem hiding this comment.
Thanks Marc,
There's no particular error as regards to this an appveyor, should I add the flake8 error am ignoring
There was a problem hiding this comment.
If there is no error in appveyor when removing this import, why do we need to keep it and ignore the flake8 issue, instead of just removing the import?
There was a problem hiding this comment.
when I remove the line completely, appveyor fails with the build below , when I leave it with the # noqa it runs.
https://ci.appveyor.com/project/airspeed-velocity/asv/builds/42489522
There was a problem hiding this comment.
What's the relevant error in the build, can you post it here please?
There was a problem hiding this comment.
C:\projects\asv\asv\commands_init_.py:84: KeyError
C:\projects\asv\asv\repo.py:313: UserError
these are the 2 errors in the build
There was a problem hiding this comment.
Thanks for that. But do you mind sharing the whole traceback of the error please. At least the error message, and the failing code. Just what you sent doesn't seem to be useful at all in understanding and diacussing the problem.
There was a problem hiding this comment.
More reference below
https://paste.ofcode.org/i6iCnChMX7ewS86bVZtA5J
https://paste.ofcode.org/i6iCnChMX7ewS86bVZtA5J
all the details are here > https://ci.appveyor.com/project/airspeed-velocity/asv/builds/42489522
.github/workflows/ci.yml
Outdated
| run: flake8 asv/__init__.py asv/config.py asv/benchmarks.py |
There was a problem hiding this comment.
Same question as in the other PR.
There was a problem hiding this comment.
This was to test the actual files I had added to this branch but I will remove it .
|
@datapythonista this PR is ready for your review will await your guidance |
There was a problem hiding this comment.
Added some comments. The files that you fix should be added to the CI. Also, since this is quite small and some changes seem repeated with another PR, it may make sense to implement the changes here there, and close this, but up to you. If you keep this open, a more descriptive description that let us know how this PR is different from he similar ones could be helpful.
asv/__init__.py
Outdated
| @@ -29,4 +29,4 @@ | |||
| if os.environ.get('__PYVENV_LAUNCHER__'): | |||
| os.unsetenv('__PYVENV_LAUNCHER__') | |||
|
|
|||
| from . import plugin_manager | |||
| from . import plugin_manager # noqa: F401 this updates command args to plugin args | |||
There was a problem hiding this comment.
This indentation doesn't make sense.
For the comment, maybe better unused, but required to load plugins
…to fix_flake8_01
|
@datapythonista this PR is ready for your review |
This PR Fixes flake8 violations in ;