Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace six.string_types and six.text_type by str #1009

Merged
merged 4 commits into from
Feb 7, 2022

Conversation

LucyJimenez
Copy link
Contributor

@LucyJimenez LucyJimenez commented Feb 5, 2022

xref #909

Replace six.string_types and six.text_type by str

@LucyJimenez LucyJimenez marked this pull request as draft February 5, 2022 01:53
@LucyJimenez LucyJimenez marked this pull request as ready for review February 5, 2022 03:19
@datapythonista
Copy link
Member

Can you rebase please?

Also, can you refer to the issue you're addressing in the first line of the PR with the format xref #1234 if you are partially addressing the issue 1234, or closes #1234 if you are fully closing it. For this PR, and the others that don't have it please. Thanks!

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, thanks @LucyJimenez for working on this.

@datapythonista datapythonista merged commit 8b0620b into airspeed-velocity:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants