Fix PEP-8 violations reported by flake8 on asv/util.py #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asv/util.py
Outdated
| @@ -566,7 +566,7 @@ def _fix_env(s): | |||
| debug_log = DebugLogBuffer(log) | |||
| dots = False | |||
| else: | |||
| debug_log = lambda c: None | |||
| debug_log = lambda c: None # noqa | |||
There was a problem hiding this comment.
We shouldn't have bare noqa, we should always specify the error we want to ignore, and why.
In this case, why we don't fix the error properly?
There was a problem hiding this comment.
You are right. I was checking the other changes first, and I'm going to fix them.
asv/util.py
Outdated
| @@ -730,7 +729,7 @@ def sig_forward(signum, frame): | |||
|
|
|||
| # Flush and disconnect debug log, if any | |||
| debug_log(None) | |||
| debug_log = lambda c: None | |||
| debug_log = lambda c: None # noqa | |||
asv/util.py
Outdated
| @@ -81,28 +81,28 @@ def reraise(self): | |||
| raise self | |||
|
|
|||
|
|
|||
| def human_list(l): | |||
| def human_list(non_human_list): | |||
There was a problem hiding this comment.
This is a normal list that wants to be printed in a human readable way. non_human_list doesn't seem to be a very clear name of what it is, maybe better just input or input_list or even list_to_format.
Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
datapythonista
approved these changes
Feb 2, 2022
|
Can you rebase please? |
Co-authored-by: Marc Garcia <garcia.marc@gmail.com>
…into check_flake8_02
…into check_flake8_02
|
Can you fix the conflicts please? |
|
Thanks @LucyJimenez, really nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/pandas-benchmarks-grant/board-issues/issues/6
Fix pep8 issues on util.py