Better error message while parsing enums #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can anyone please review this pull request. |
| return valueOf.invoke(null, value); | ||
| } | ||
| catch (InvocationTargetException e) { | ||
| String errorMsg = "Invalid " + name + ", Valid values are: " + Joiner.on(", ").join(type.getEnumConstants()); |
There was a problem hiding this comment.
Please don't abbreviate variable names. This can just be message
There was a problem hiding this comment.
Use String.format() instead of concatenation
There was a problem hiding this comment.
.getEnumConstants() returns null if the type is not an enum. This error message should only be generated for enums.
|
@electrum : I have addressed review comments. |
|
This need to use .name()
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.