Missing required option doesn't throw #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposed fix for: airlift#22 This approach introduces a ParseResult object which allows for the collection of multiple parse errors from the user input and then provides this back to the caller to decide what to do. E.G. send the user the to the help dialog. This keeps the existing API and fits with the desire to keep the parsing logic agnostic to the details of the HelpOption. The existing pattern still fails fast with an exception: ```java MyCommand command = SingleCommand.singleCommand(MyCommand.class).parse(args); ``` This fix introduces the following pattern from the caller's perspective: ```java ParseResult parseResult = new ParseResult(); MyCommand command = SingleCommand.singleCommand(MyCommand.class).parse(args, parseResult); command.helpOption.runOrShowHelp(parseResult, command); ``` The call to runOrShowHelp will: * Run the command if there are no parse errors and help has not been requsted * Will display help if it is requested regardless of whether there are parse errors * Will display parse errors and help when there are parse errors
Removed parent pom reference and changed orgId coordinates to allow new fork in maven central
Sonatype requires it's pom be the parent to support uploads. Followed steps outlined here: https://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repository+Usage+Guide
This is helpful for commands to be able to show the Help text if they have a validation failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for: #22
This approach introduces a ParseResult object which allows for the collection of multiple parse errors from the user input
and then provides this back to the caller to decide what to do. E.G. send the user the to the help dialog.
This keeps the existing API and fits with the desire to keep the parsing logic agnostic to the details of the HelpOption.
The existing pattern still fails fast with an exception:
This fix introduces the following pattern from the caller's perspective:
The call to runOrShowHelp will: