-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nested objects and array support #4
Add nested objects and array support #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work! I booted up the sample app and everything seems to be working correctly. I had a few comments but largely looks good.
Whoops, didn't mean to request a review from myself 😆 |
@airjp73. Thanks for those comments! I implemented them and marked them as resolved. Check my replies and feel free to let me know if you have any other feedback. I'll work in the documentation and let you know as soon as it's ready. |
It's looking good to me. 👍 |
…e & downgrade to EsLint 7 I upgraded EsLint to v8 but is having some problems with ES Module. We can investigate it later
@airjp73 This one is now ready for review.
This PR is now longer in Draft so feel free to merge it when you are ready. 🥳 |
Looks good, thanks! |
@lucascurti, I just published the changes under 1.1.1-beta.0 in case you wanted to use it right away. I'm gonna work on the other issues I made before releasing so I can bump the major version. |
Cool! I'll update to the beta tomorrow. |
I'll check it out 👍 |
@airjp73 I still need to create some tests and work on the documentation updates but the nested objects and arrays should be working. It would be great if you can play a bit with it and let me know what you think. I didn't implemented the option to turn off nesting completely for a field using brackets. I think that one can be added in a later PR.
To run the
sample-app
just runnpm run sample-app
in the root folder.I'm keeping this one as draft until documentation and tests are added.