[Fix] PM2.5 compensated show on display #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-4711
reviewed
Aug 25, 2024
src/AgOledDisplay.cpp
Outdated
| } | ||
| DISP()->setFont(u8g2_font_t0_22b_tf); | ||
| if (config.isPmStandardInUSAQI()) { | ||
| if (utils::isValidPMS(value.pm25_1)) { | ||
| sprintf(strBuf, "%d", ag->pms5003.convertPm25ToUsAqi(value.pm25_1)); | ||
| if (utils::isValidPMS(pm25)) { |
There was a problem hiding this comment.
the method name isValidPMS is misleading, propose to rename to simply isValid()
There was a problem hiding this comment.
it's the API on utils can not use isValid cause there are multiple API check sensor valid like CO2, Temperature, etc.
There was a problem hiding this comment.
OK, then I propose to write
isValidPm()
There was a problem hiding this comment.
@nick-4711
Updated 753f229
nick-4711
reviewed
Aug 25, 2024
src/AgOledDisplay.cpp
Outdated
| @@ -307,20 +307,21 @@ void OledDisplay::showDashboard(const char *status) { | |||
| int pm25 = value.pm25_1; | |||
| if (config.hasSensorSHT) { | |||
| pm25 = ag->pms5003.compensated(pm25, value.Humidity); | |||
There was a problem hiding this comment.
the method name should be renamed to compensate()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update missing add PM2.5 compensated before show on display. #221