Fix LED bar flickers #138
Merged
Fix LED bar flickers #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-4711
reviewed
May 17, 2024
| if (configuration.isLedBarModeChanged()) { | ||
| Serial.println("Set 'ledBarMode' " + String(configuration.getLedBarMode())); | ||
| Serial.println("Get 'ledBarBrightness' " + String(configuration.getLedBarBrightness())); | ||
| if (configuration.getLedBarBrightness() == 0) { |
There was a problem hiding this comment.
I think the code is redundant to what we have on line 843 onwards?
There was a problem hiding this comment.
Yes a bit of same.
at 843: focus to set brightness
at 849: focus to enable/disable LED bar.
nick-4711
reviewed
May 20, 2024
examples/OneOpenAir/OneOpenAir.ino
Outdated
| if (configuration.getLedBarMode() != LedBarMode::LedBarModeOff) { | ||
| ag->ledBar.setEnable(true); | ||
| } | ||
| ag->ledBar.setBrighness(configuration.getLedBarBrightness()); |
There was a problem hiding this comment.
setBrighness -> setBrightness
nick-4711
approved these changes
May 28, 2024
examples/OneOpenAir/OneOpenAir.ino
Outdated
| String(configuration.getLedBarBrightness())); | ||
| } | ||
|
|
||
| if (configuration.isLedBarModeChanged()) { | ||
| Serial.println("Set 'ledBarMode' " + String(configuration.getLedBarMode())); |
There was a problem hiding this comment.
I think we do not really "set" the ledBarMode then later on?
There was a problem hiding this comment.
Ok, I'll remove it. It's just for test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.