-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ingressClassName
value to ingress
#527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fkoetzner this looks good now, with only one random diff to be fixed.
Also, you can re-open closed PRs, you don't have to make new ones, otherwise, it's sort of spammy.
@fkoetzner I just realised that we haven't added Can you clarify if
|
Signed-off-by: fkoetzner <florian.koetzner@baeckerai.de>
Yes, you're right. I thought it was only added to |
ingressClassName
value to ingress
What issues does your PR fix?
ingressClassName
#427ingressClassName
#426What does your PR do?
ingressClassName
on the Ingress resources:ingress.web.ingressClassName
ingress.flower.ingressClassName
Checklist
For all Pull Requests
For releasing ONLY
P.S.: Sorry, I accidentally closed the original pull request #524.