Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load CDK: Remove ScopedTask interface, simplify TaskScopeProvider #51051

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Load CDK: Remove ScopedTask interface, simplify TaskScopeProvider #51051

wants to merge 1 commit into from
+210 −159

Conversation

johnny-schmidt
Copy link
Contributor

What

  • Removes the ScopedTask interface, migrates the functionality to explicit booleans on the Task interface.
  • Simplifies the TaskScopeProvider CoroutineScopes to the built-in default and IO dispatchers
  • Simplifies shutdown semantics
  • also remove unnecessary @secondary

Enables

  • further simplification of shutdown/failure
  • removing the per-task task and task factory interfaces

@johnny-schmidt johnny-schmidt requested a review from a team as a code owner January 11, 2025 00:48
@vercel Vercel
Copy link

vercel bot commented Jan 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 1:02am

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jan 11, 2025
@johnny-schmidt johnny-schmidt force-pushed the jschmidt/load-cdk/remove-scope-interface branch from 3472dda to 16e598a Compare January 11, 2025 00:49
@johnny-schmidt johnny-schmidt force-pushed the jschmidt/load-cdk/remove-scope-interface branch from 16e598a to 8aeda22 Compare January 11, 2025 00:54
@davinchia
Copy link
Contributor

@johnny-schmidt awesome! I'm thinking it's useful to specifically tag the folks who provided this feedback to make sure we are all aligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnny-schmidt @davinchia @octavia-squidington-iii