Destination-S3-V2: Bug: Do not hang on stream missing state #51043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
edgao
approved these changes
Jan 10, 2025
tryangul
reviewed
Jan 10, 2025
| import kotlinx.coroutines.test.runTest | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| class CheckpointManagerUTest { |
There was a problem hiding this comment.
Do we not need to extend this via @ExtendWith(MockKExtension::class) to get the mock annotations working?
There was a problem hiding this comment.
I guess not? I stepped through with the debugger and the catalog was populated with a mock that was behaving as expected.
johnny-schmidt
deleted the
jschmidt/s3v2/fix-sync-hands-if-stream-missing-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://github.com/airbytehq/airbyte-internal-issues/issues/11331
Syncs were hanging when we did not get state for some streams, because we were returning early when one stream was empty.
I verified that the unit test case here fails if the
continueis reverted back to areturnI also added logs to the cases where an attempt to flush would not return a result